Skip to content

Commit

Permalink
rename frameworkCliVersion to pinFrameworkCli
Browse files Browse the repository at this point in the history
  • Loading branch information
dario-piotrowicz committed Dec 11, 2024
1 parent d2bd8b1 commit c36670d
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion packages/create-cloudflare/src/frameworks/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export const getFrameworkCli = (ctx: C3Context, withVersion = true) => {
const frameworkCli = ctx.template
.frameworkCli as keyof typeof frameworksPackageJson.dependencies;
const version =
ctx.template.frameworkCliVersion ??
ctx.template.pinFrameworkCli ??
frameworksPackageJson.dependencies[frameworkCli];
return withVersion ? `${frameworkCli}@${version}` : frameworkCli;
};
Expand Down
6 changes: 3 additions & 3 deletions packages/create-cloudflare/src/templates.ts
Original file line number Diff line number Diff line change
Expand Up @@ -76,10 +76,10 @@ export type TemplateConfig = {
/** The name of the framework cli tool that is used to generate this project or undefined if none */
frameworkCli?: string;
/**
* The version of the framework cli tool to use.
* If omitted the cli version is taken from src/frameworks/package.json, which is the default/standard behavior.
* A specific version of the framework cli tool to use instead of the standard one taken from the src/frameworks/package.json
* (which gets managed and bumped by dependabot)
*/
frameworkCliVersion?: string;
pinFrameworkCli?: string;
/** When set to true, hides this template from the selection menu */
hidden?: boolean;
/** Specifies a set of files that will be copied to the project directory during creation.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export default {
// TODO: here we need to specify a version of create-next-app which is different from the
// standard one used in the stable Next.js template, that's because our open-next adapter
// is not yet fully ready for Next.js 15, once it is we should remove the following
frameworkCliVersion: "14.2.5",
pinFrameworkCli: "14.2.5",
platform: "workers",
displayName: "Next (using Node.js compat + Workers Assets)",
path: "templates-experimental/next",
Expand Down

0 comments on commit c36670d

Please sign in to comment.