Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Packages #4291

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Version Packages #4291

merged 1 commit into from
Nov 16, 2023

Conversation

workers-devprod
Copy link
Contributor

@workers-devprod workers-devprod commented Oct 27, 2023

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

[email protected]

Minor Changes

Patch Changes

[email protected]

Minor Changes

  • #4324 16cc2e92 Thanks @penalosa! - Update to latest [email protected]

  • #4322 8a25b7fb Thanks @dario-piotrowicz! - add unsafeEvalBinding option

    Add option to leverage the newly introduced UnsafeEval workerd binding API,
    such API is used to evaluate javascript code at runtime via the provided eval and newFunction methods.

    The API, for security reasons (as per the workers docs), is not to be use in production but it is intended for local purposes only such as local testing.

    To use the binding you need to specify a string value for the unsafeEvalBinding, such will be the name of the UnsafeEval bindings that will be made available in the workerd runtime.

    For example the following code shows how to set the binding with the UNSAFE_EVAL name and evaluate the 1+1 string:

    const mf = new Miniflare({
    	log,
    	modules: true,
    	script: `
          export default {
              fetch(req, env, ctx) {
                  const two = env.UNSAFE_EVAL.eval('1+1');
                  return new Response('two = ' + two); // returns 'two = 2'
              }
          }
      `,
    	unsafeEvalBinding: "UNSAFE_EVAL",
    });

Patch Changes

  • #4397 4f8b3420 Thanks @mrbbot! - fix: reject Miniflare#ready promise if Miniflare#dispose() called while waiting

  • #4428 3637d97a Thanks @mrbbot! - fix: add miniflare bin entry

    Miniflare 3 doesn't include a CLI anymore, but should log a useful error stating this when running npx miniflare. We had a script for this, but it wasn't correctly hooked up. 🤦 This change makes sure the required bin entry exists.

  • #4321 29a59d4e Thanks @mrbbot! - fix: ensure Mutex doesn't report itself as drained if locked

    Previously, Miniflare's Mutex implementation would report itself as drained
    if there were no waiters, regardless of the locked state. This bug meant that
    if you called but didn't await Miniflare#setOptions(), future calls to
    Miniflare#dispatchFetch() (or any other asynchronous Miniflare method)
    wouldn't wait for the options update to apply and the runtime to restart before
    sending requests. This change ensures we wait until the mutex is unlocked before
    reporting it as drained.

  • #4307 7fbe1937 Thanks @jspspike! - Only output ipv4 addresses when starting

  • #4400 76787861 Thanks @mrbbot! - fix: cleanup temporary directory after shutting down workerd

    Previously on exit, Miniflare would attempt to remove its temporary directory
    before shutting down workerd. This could lead to EBUSY errors on Windows.
    This change ensures we shutdown workerd before removing the directory.
    Since we can only clean up on a best effort basis when exiting, it also catches
    any errors thrown when removing the directory, in case the runtime doesn't
    shutdown fast enough.

@cloudflare/[email protected]

Minor Changes

  • #4051 4578d647 Thanks @taoky! - fix: remove extension name check when generating response

    Current regex logic to check whether a pathname is a file (has file extension) is causing trouble for some websites, and now \${pathname}/index.html is always checked before returning notFound().

Patch Changes

[email protected]

Minor Changes

  • #4347 102e15f9 Thanks @Skye-31! - Feat(unstable_dev): Provide an option for unstable_dev to perform the check that prompts users to update wrangler, defaulting to false. This will prevent unstable_dev from sending a request to NPM on startup to determine whether it needs to be updated.

  • #4179 dd270d00 Thanks @matthewdavidrodgers! - Simplify secret:bulk api via script settings

    Firing PUTs to the secret api in parallel has never been a great solution - each request independently needs to lock the script, so running in parallel is at best just as bad as running serially.

    Luckily, we have the script settings PATCH api now, which can update the settings for a script (including secret bindings) at once, which means we don't need any parallelization. However this api doesn't work with a partial list of bindings, so we have to fetch the current bindings and merge in with the new secrets before PATCHing. We can however just omit the value of the binding (i.e. only provide the name and type) which instructs the config service to inherit the existing value, which simplifies this as well. Note that we don't use the bindings in your current wrangler.toml, as you could be in a draft state, and it makes sense as a user that a bulk secrets update won't update anything else. Instead, we use script settings api again to fetch the current state of your bindings.

    This simplified implementation means the operation can only fail or succeed, rather than succeeding in updating some secrets but failing for others. In order to not introduce breaking changes for logging output, the language around "${x} secrets were updated" or "${x} secrets failed" is kept, even if it doesn't make much sense anymore.

Patch Changes

@workers-devprod workers-devprod requested review from a team as code owners October 27, 2023 16:24
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #4291 (03c3880) into main (2be0f3f) will increase coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4291      +/-   ##
==========================================
+ Coverage   75.46%   75.50%   +0.03%     
==========================================
  Files         225      225              
  Lines       12478    12478              
  Branches     3239     3239              
==========================================
+ Hits         9417     9421       +4     
+ Misses       3061     3057       -4     

see 3 files with indirect coverage changes

@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6896356992/npm-package-wrangler-4291

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6896356992/npm-package-wrangler-4291

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6896356992/npm-package-wrangler-4291 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6896356992/npm-package-miniflare-4291
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6896356992/npm-package-cloudflare-pages-shared-4291

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20231030.0
workerd 1.20231030.0 1.20231030.0
workerd --version 1.20231030.0 2023-10-30

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@workers-devprod workers-devprod force-pushed the changeset-release/main branch 3 times, most recently from fad5c83 to 5e9e3d7 Compare October 27, 2023 21:04
@workers-devprod workers-devprod requested a review from a team as a code owner October 27, 2023 21:04
@workers-devprod workers-devprod force-pushed the changeset-release/main branch 14 times, most recently from 55d1e80 to 391791b Compare November 2, 2023 12:30
@workers-devprod workers-devprod requested a review from a team as a code owner November 2, 2023 12:30
@workers-devprod workers-devprod force-pushed the changeset-release/main branch 6 times, most recently from b90b688 to 62a95e5 Compare November 3, 2023 16:24
@workers-devprod workers-devprod force-pushed the changeset-release/main branch 18 times, most recently from 77c6ec3 to 47423e8 Compare November 13, 2023 16:07
@workers-devprod workers-devprod force-pushed the changeset-release/main branch 4 times, most recently from bd2eb01 to f884b56 Compare November 16, 2023 15:46
@lrapoport-cf lrapoport-cf merged commit 08615aa into main Nov 16, 2023
27 checks passed
@lrapoport-cf lrapoport-cf deleted the changeset-release/main branch November 16, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: wrangler login only lists the first 20 accounts
5 participants