Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wrangler): add local DO support with getPlatformProxy #7087

Closed
wants to merge 1 commit into from

Conversation

edmundhung
Copy link
Member

@edmundhung edmundhung commented Oct 24, 2024

Fixes n/a.

The getPlatformProxy() API was designed for framework integrations on Cloudflare Pages with DO support limited to external workers only (i.e. DO with script_name specified).

This PR enables local DO binding support (including RPC) if the user is building on Cloudflare Workers (e.g. with Static Assets).


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because:

Copy link

changeset-bot bot commented Oct 24, 2024

⚠️ No Changeset found

Latest commit: f4d8768

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 24, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11576406623/npm-package-wrangler-7087

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7087/npm-package-wrangler-7087

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11576406623/npm-package-wrangler-7087 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11576406623/npm-package-create-cloudflare-7087 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11576406623/npm-package-cloudflare-kv-asset-handler-7087
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11576406623/npm-package-miniflare-7087
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11576406623/npm-package-cloudflare-pages-shared-7087
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11576406623/npm-package-cloudflare-vitest-pool-workers-7087
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11576406623/npm-package-cloudflare-workers-editor-shared-7087
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11576406623/npm-package-cloudflare-workers-shared-7087
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11576406623/npm-package-cloudflare-workflows-shared-7087

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241022.0
workerd 1.20241022.0 1.20241022.0
workerd --version 1.20241022.0 2024-10-22

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@edmundhung edmundhung force-pushed the edmundhung/platform-proxy-worker-do branch 2 times, most recently from 7d94102 to 2c22d70 Compare October 29, 2024 12:34
@edmundhung edmundhung force-pushed the edmundhung/platform-proxy-worker-do branch from 2c22d70 to f4d8768 Compare October 29, 2024 14:48
@edmundhung edmundhung changed the title fix(miniflare): no service is defined feat(wrangler): add local DO support with getPlatformProxy Oct 29, 2024
edmundhung added a commit that referenced this pull request Nov 19, 2024
@edmundhung
Copy link
Member Author

Closing this in favor of #7292

@edmundhung edmundhung closed this Nov 19, 2024
@edmundhung edmundhung deleted the edmundhung/platform-proxy-worker-do branch November 19, 2024 16:18
edmundhung added a commit that referenced this pull request Nov 19, 2024
edmundhung added a commit that referenced this pull request Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant