Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update unenv preset #7581

Merged
merged 2 commits into from
Dec 22, 2024
Merged

Update unenv preset #7581

merged 2 commits into from
Dec 22, 2024

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Dec 18, 2024

Add tests for the unenv preset

We will need to mobve those tests to the package, see #7579

dns is expected to fail before we upgrade to workerd 20241216

The second commit speed-up the tests by launching wrangler only once for all the tests.

/cc @pi0

edit: this PR does not change the resolution mechanism (which is what broke the wrangler a few days ago).


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: no user facing changes

Copy link

changeset-bot bot commented Dec 18, 2024

🦋 Changeset detected

Latest commit: b063e35

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vicb vicb requested a review from petebacondarwin December 18, 2024 08:43
@vicb vicb added e2e Run e2e tests on a PR no-changeset-required labels Dec 18, 2024
@vicb vicb changed the title fixtures-preset Add tests for the unenv preset Dec 18, 2024
Copy link
Contributor

github-actions bot commented Dec 18, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12453728474/npm-package-wrangler-7581

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7581/npm-package-wrangler-7581

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12453728474/npm-package-wrangler-7581 dev path/to/script.js
Additional artifacts:
wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12453728474/npm-package-cloudflare-workers-bindings-extension-7581 -O ./cloudflare-workers-bindings-extension.0.0.0-vf733292df.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vf733292df.vsix
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12453728474/npm-package-create-cloudflare-7581 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12453728474/npm-package-cloudflare-kv-asset-handler-7581
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12453728474/npm-package-miniflare-7581
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12453728474/npm-package-cloudflare-pages-shared-7581
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12453728474/npm-package-cloudflare-unenv-preset-7581
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12453728474/npm-package-cloudflare-vitest-pool-workers-7581
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12453728474/npm-package-cloudflare-workers-editor-shared-7581
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12453728474/npm-package-cloudflare-workers-shared-7581
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12453728474/npm-package-cloudflare-workflows-shared-7581

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241218.0
workerd 1.20241218.0 1.20241218.0
workerd --version 1.20241218.0 2024-12-18

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@vicb vicb requested a review from a team as a code owner December 19, 2024 17:14
@vicb vicb force-pushed the fixtures-preset branch 2 times, most recently from 58e891a to 82f1ed0 Compare December 19, 2024 18:03
@vicb vicb requested a review from petebacondarwin December 19, 2024 20:05
@vicb vicb changed the title Add tests for the unenv preset Update unenv preset Dec 19, 2024
@vicb vicb mentioned this pull request Dec 20, 2024
9 tasks
@vicb vicb merged commit cac7fa6 into main Dec 22, 2024
27 of 31 checks passed
@vicb vicb deleted the fixtures-preset branch December 22, 2024 11:49
penalosa pushed a commit that referenced this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e tests on a PR
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants