Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enables codec entries for outputs in the ingestor_syslog job. #138

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jvikes11
Copy link

@jvikes11 jvikes11 commented Apr 3, 2019

When setting the property ingestor_syslog.ouputs with additional logstash outputs the codec field was being set to a string. According to the documentation the codec field value for any available output is an object and not a string or integer.

https://www.elastic.co/guide/en/logstash/current/codec-plugins.html

When settings the property ingestor_syslog.ouputs with additional logstash outputs
the codec field was being set to an string. According to the documentation
the codec field value for any available output is an object and
not a string or integer.

Signed-off-by: Alan Moran <[email protected]>
@CLAassistant
Copy link

CLAassistant commented Apr 3, 2019

CLA assistant check
All committers have signed the CLA.

@bonzofenix
Copy link
Member

@Infra-Red can you take a look at this? Thanks!

Copy link
Member

@Infra-Red Infra-Red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jvikes11 @bonzofenix ! Thanks for the PR! I have few questions before attempting to merge.

  1. Since codec plugin could be applied to both input and output plugins I prefer to have the same option added to input plugins.

  2. Codec plugin may have additional nested options, please see the avro plugin usage example, but with the current implementation they will be just skipped.

Could you please take a look at these issues?

@bonzofenix
Copy link
Member

bonzofenix commented Jul 23, 2019

what do you think about just replacing in the original implementation:
<%= k %> => <%= v.inspect %>
with just:
<%= k %> => <%= v %>

This would be a breaking change for anyone using this property but it would allow people to apply any nested config and #inspect would not break the => notation.

@bonzofenix
Copy link
Member

the same could apply for inputs:

@axelaris axelaris removed the request for review from hannayurkevich August 13, 2019 11:50
@axelaris
Copy link
Member

Since it's introduces a breaking change to release, I would love to see some 👍or 👎on that from community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants