-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enables codec entries for outputs in the ingestor_syslog job. #138
base: develop
Are you sure you want to change the base?
Conversation
When settings the property ingestor_syslog.ouputs with additional logstash outputs the codec field was being set to an string. According to the documentation the codec field value for any available output is an object and not a string or integer. Signed-off-by: Alan Moran <[email protected]>
@Infra-Red can you take a look at this? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jvikes11 @bonzofenix ! Thanks for the PR! I have few questions before attempting to merge.
-
Since codec plugin could be applied to both input and output plugins I prefer to have the same option added to input plugins.
-
Codec plugin may have additional nested options, please see the avro plugin usage example, but with the current implementation they will be just skipped.
Could you please take a look at these issues?
what do you think about just replacing in the original implementation: This would be a breaking change for anyone using this property but it would allow people to apply any nested config and #inspect would not break the |
the same could apply for inputs: logsearch-boshrelease/jobs/ingestor_syslog/templates/config/input_and_output.conf.erb Line 40 in 799a42d
|
Since it's introduces a breaking change to release, I would love to see some 👍or 👎on that from community. |
When setting the property ingestor_syslog.ouputs with additional logstash outputs the codec field was being set to a string. According to the documentation the codec field value for any available output is an object and not a string or integer.
https://www.elastic.co/guide/en/logstash/current/codec-plugins.html