safe app deletion always retry on any error #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our apps are failing to be deleted because some services can only unbound to one app at a time.
Our issue has been solved temporarily by #547, but at some point the error message changed without notice, so the workaround wasn't cutting it anymore.
Knowing that the service broker messages can not be relied on, I think that it is best to retry app deletion on any error. In the worst case, if this is an error that cannot be solved by retrying only, then we will only loose a few minutes, but this is better than a Terraform apply failing and interrupting a deployment procedure.