Add public TLS endpoint for blobstore #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 18, 2024
Co-authored-by: David Alvarado <[email protected]> Co-authored-by: Amelia Downs <[email protected]>
sethboyles
force-pushed
the
blobstore_tls
branch
from
ead76d5 to
49f2aba
Compare
ameowlia
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the package and droplet download/upload endpoints redirect to the public port of the singleton-blobstore (if used) which does not support TLS. This adds a TLS server to the singleton-blobstore's nginx conf.
This change was designed to be consumed without any changes from a bosh manifest/cf-deployment. That is, not supplying a SSL certificate in the manifest will simply cause the TLS server to not be render to the blobstore's nginx conf, and the download/upload endpoints will continue to redirect to the non-TLS port. There will be a corresponding PR to cf-deployment soon, and some time after that is merged, we can remove the non-TLS ports entirely.
I have viewed signed and have submitted the Contributor License Agreement
I have made this pull request to the
developbranchI have run CF Acceptance Tests on bosh lite