Acceptance test for file based service bindings #1374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* pushed buildpack app, enables app feature "file-based-service-bindings" and binds a user-provided service * then checks service binding files via app /file endpoint * test is skipped if "include_file_based_service_bindings" if false
* merge common coding into one "callback" function * use "lifecycle" string constants for different execution paths
philippthun
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change about?
Acceptance test for the file-based service bindings feature. This PR introduces a new CATs config flag
include_file_based_service_bindingsfor the new tests (default isfalse). The test checks that file-based service bindings works for a regular buildpack app and for a CNB lifecycle app. Test for a Docker app will follow.Please provide contextual information.
RFC0030
What version of cf-deployment have you run this cf-acceptance-test change against?
v45.0.0 with patched capi-release and diego-release
Please check all that apply for this PR:
Did you update the README as appropriate for this change?
If you are introducing a new acceptance test, what is your rationale for including it CATs rather than your own acceptance test suite?
File-based service bindings will be generally available with an upcoming cf-deployment release.
How many more (or fewer) seconds of runtime will this change introduce to CATs?
90 seconds per test
What is the level of urgency for publishing this change?