-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC0027 Enable "update-route", "create-route", "map-route", "routes", "route", "apps" & "app" to manage generic per-route options #3366
Draft
Dariquest
wants to merge
17
commits into
cloudfoundry:v8
Choose a base branch
from
sap-contributions:updateRouteCommands
base: v8
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLI Support for Generic Per-Route Options
Introducing a new cli command 'update-route', which allows updates to route resources.
Extending the API of the Route to contain per route options and particularly the first one called "loadbalancing", containing a load balancing algorithm of a route.
Existing commands "create-route", "map-route", "routes", "route", "apps", "app" were also extended to accept and output the per-route options.
Detailed specification including that of for all the involved components is provided in the RFC
It is possible to provide options in the create-route and map-route commands.
Why Is This PR Valuable?
Allow users to manage per-route options via the CLI instead of having to talk to the API directly.
Applicable Issues
GitHub Issue
How Urgent Is The Change?
No urgency