add otel collector service telemetry metrics #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Turns out source_id and origin are different for app logs/metrics, but synced for component logs/metrics which this is. |
Configure a prometheus endpoint which serves metrics about the otel-collector itself. Also adds a prom_scraper_config so promscraper scrapes the metrics. Signed-off-by: Rebecca Roberts <[email protected]>
mkocher
force-pushed
the
add-otel-service-telemetry-metrics
branch
from
13d0d01
to
0815d9d
Compare
ctlong
previously approved these changes
Aug 18, 2023
When OTel Collector jobs are disabled, don't output any prom scraper configuration so that the prom scraper skips over these jobs. This avoids continual error messages logged by the prom scraper when it can't scrape a destination.
Signed-off-by: Andrew Crump <[email protected]>
Since we already dropped exact parity with OTel Collector settings with `ingress.grpc.tls.*`, we think it's preferable to remove the `service.` prefix from telemetry properties in the OTel Collector jobs. Signed-off-by: Carson Long <[email protected]>
ctlong
approved these changes
Aug 18, 2023
acrmp
pushed a commit
to cloudfoundry/otel-collector-release
that referenced
this pull request
Dec 6, 2023
…r-agent-release#364) * add otel collector service telemetry metrics Configure a prometheus endpoint which serves metrics about the otel-collector itself. Also adds a prom_scraper_config so promscraper scrapes the metrics. * add otel service telemetry metrics to windows jobs * fix: selectively enable prom scraping of otel collectors When OTel Collector jobs are disabled, don't output any prom scraper configuration so that the prom scraper skips over these jobs. This avoids continual error messages logged by the prom scraper when it can't scrape a destination. * fix(otel-collector-windows): align default port with otel-collector * refactor: remove service prefix from telemetry properties Since we already dropped exact parity with OTel Collector settings with `ingress.grpc.tls.*`, we think it's preferable to remove the `service.` prefix from telemetry properties in the OTel Collector jobs. --------- Signed-off-by: Rebecca Roberts <[email protected]> Signed-off-by: Andrew Crump <[email protected]> Signed-off-by: Carson Long <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configure a prometheus endpoint which serves metrics about the otel-collector itself. Also adds a prom_scraper_config so promscraper scrapes the metrics.
Type of change
Testing performed?
Checklist:
mainbranch, or relevant version branch