Fix app wall table app link (#1348)

* Fix the app wall table app link
- Default hashbang prefix is now '!'
- Instead of adding '!', update to use ui-sref
- See https://docs.angularjs.org/guide/migration#commit-aa077e8

* Fix lint issue

* trivial change to retrigger pipeline

* Fix lint

components/cloud-foundry/frontend/src/view/applications/list/table-view/table-view.directive.js

@@ -87,19 +87,8 @@
         }
       });
 
-    this.getAppSummaryLink = getAppSummaryLink;
     this.stMiddleware = stMiddleware;
 
-    /**
-     * @name getAppSummaryLink
-     * @description Get link to application summary page
-     * @param {object} app The application object
-     * @returns {string} returns the link to the app summary page
-     */
-    function getAppSummaryLink(app) {
-      return '#/cf/applications/' + app.clusterId + '/app/' + app.metadata.guid + '/summary';
-    }
-
     function stMiddleware(tableState) {
       var stSort = tableState.sort.predicate + '_' + !tableState.sort.reverse;
       var sort = model.currentSortOption + '_' + model.sortAscending;

components/cloud-foundry/frontend/src/view/applications/list/table-view/table-view.html

@@ -26,7 +26,7 @@
     <tbody>
     <tr ng-repeat="app in tableViewCtrl.stApps">
       <td class="table-view-app-name">
-        <a ng-href="{{ tableViewCtrl.getAppSummaryLink(app) }}">{{ app.entity.name }}</a>
+        <a ui-sref="cf.applications.application.summary({ cnsiGuid: app.clusterId, guid: app.metadata.guid })">{{ app.entity.name }}</a>
       </td>
       <td>
         <div class="app-state-column">

components/cloud-foundry/frontend/test/unit/view/applications/list/table-view.directive.spec.js

@@ -38,11 +38,6 @@
         expect(applicationsTableDirectiveCtrl).toBeDefined();
       });
 
-      it('should return correct URL', function () {
-        var urlString = applicationsTableDirectiveCtrl.getAppSummaryLink(apps[0]);
-        expect(urlString).toEqual('#/cf/applications/testGuid/app/appGuid/summary');
-      });
-
     });
 
   });