me-17961: test if videos on colors api page are playing #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cld-vp-esm-pages ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for cld-video-player ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ehab-cl
approved these changes
Dec 23, 2024
test/e2e/specs/colorsApiPage.spec.ts
Outdated
Comment on lines
14
to
22
| await test.step('Validating that the first video is playing (in case isPause is false)', async () => { | ||
| expect(await pomPages.colorsApiPage.colorsApiColorSkinVideoComponent.validateVideoPaused(false)); | ||
| }); | ||
| await test.step('Validating that the second video is playing (in case isPause is false)', async () => { | ||
| expect(await pomPages.colorsApiPage.colorsApiDarkSkinVideoComponent.validateVideoPaused(false)); | ||
| }); | ||
| await test.step('Scroll until the third video element is visible', async () => { | ||
| await pomPages.colorsApiPage.colorsApiLightSkinVideoComponent.locator.scrollIntoViewIfNeeded(); | ||
| }); |
There was a problem hiding this comment.
I would name the videos by their configuration description so instead of first video i would say for example validating that the modified colors video or for example the dark skin video ... this will make it easier to understand what failed when tests fail.
There was a problem hiding this comment.
Modified the test steps description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant task - https://cloudinary.atlassian.net/browse/ME-17961
This test is navigating to colors API page (colors.html) and make sure that 3 videos element are playing (checking that the video is not paused).