Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

me-17969: test if video on playlist by tag page is playing #782

Merged
merged 4 commits into from
Jan 6, 2025
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion test/e2e/specs/cldAnalyticsPage.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@ vpTest(`Test if 4 videos on Cloudinary analytics page are playing as expected`,
await waitForPageToLoadWithTimeout(page, 5000);
});
await test.step('Validating that Cloudinary analytics video is playing', async () => {
await pomPages.cldAnalyticsPage.cldAnalyticsVideoComponent.validateVideoIsPlaying(true);
await expect(async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you add wrap it with toPass?

Copy link
Contributor Author

@ShayLevi ShayLevi Jan 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cloudinary Analytics page video spec was failing and failed the PR. It takes some time to the video start playing so I added toPass to the first video and it works. After discussion the toPass wrap moved to validateVideoIsPlaying inside as part of the video component.

await pomPages.cldAnalyticsPage.cldAnalyticsVideoComponent.validateVideoIsPlaying(true);
}).toPass({ intervals: [500], timeout: 3000 });
});
await test.step('Validating that Cloudinary analytics ADP video is playing', async () => {
await pomPages.cldAnalyticsPage.cldAnalyticsAdpVideoComponent.validateVideoIsPlaying(true);
Expand Down
17 changes: 17 additions & 0 deletions test/e2e/specs/playlistByTagPage.spec.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
import { vpTest } from '../fixtures/vpTest';
import { test } from '@playwright/test';
import { waitForPageToLoadWithTimeout } from '../src/helpers/waitForPageToLoadWithTimeout';
import { getLinkByName } from '../testData/pageLinksData';
import { ExampleLinkName } from '../testData/ExampleLinkNames';

const link = getLinkByName(ExampleLinkName.PlaylistByTag);

vpTest(`Test if video on playlist by tag page is playing as expected`, async ({ page, pomPages }) => {
await test.step('Navigate to playlist by tag page by clicking on link', async () => {
await pomPages.mainPage.clickLinkByName(link.name);
await waitForPageToLoadWithTimeout(page, 5000);
});
await test.step('Validating that playlist by tag video is playing', async () => {
await pomPages.playlistByTagPage.playlistByTagVideoComponent.validateVideoIsPlaying(true);
});
});
5 changes: 5 additions & 0 deletions test/e2e/src/pom/PageManager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import { FluidLayoutsPage } from './fluidLayoutsPage';
import { ForceHlsSubtitlesPage } from './forceHlsSubtitlesPage';
import { MultiplePlayersPage } from './multiplePlayersPage';
import { PlaylistPage } from './playlistPage';
import { PlaylistByTagPage } from './playlistByTagPage';

/**
* Page manager,
Expand Down Expand Up @@ -136,5 +137,9 @@ export class PageManager {
public get playlistPage(): PlaylistPage {
return this.getPage(PlaylistPage);
}

public get playlistByTagPage(): PlaylistByTagPage {
return this.getPage(PlaylistByTagPage);
}
}
export default PageManager;
16 changes: 16 additions & 0 deletions test/e2e/src/pom/playlistByTagPage.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
import { Page } from '@playwright/test';
import { VideoComponent } from '../../components/videoComponent';
import { BasePage } from './BasePage';
const PLAYLIST_BY_TAG_PAGE_VIDEO_SELECTOR = '//*[@id="player_html5_api"]';

/**
* Video player examples playlist by tag page object
*/
export class PlaylistByTagPage extends BasePage {
public playlistByTagVideoComponent: VideoComponent;

constructor(page: Page) {
super(page);
this.playlistByTagVideoComponent = new VideoComponent(page, PLAYLIST_BY_TAG_PAGE_VIDEO_SELECTOR);
}
}
Loading