Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retrieve file after store #489

Merged
merged 1 commit into from
Apr 5, 2022
Merged

Retrieve file after store #489

merged 1 commit into from
Apr 5, 2022

Conversation

david-zw-liu
Copy link
Contributor

@david-zw-liu david-zw-liu commented Mar 25, 2022 •
edited
Loading

Brief Summary of Changes

Try to fix the problem, that model.image.file will be nil even if the file is uploaded.
Calling retrieve_from_store! after store! called can populate @file and @identifier variable.
So that will fix this problem.

What does this PR address?

Are tests included?

  • Yes
  • No

Reviewer, please note:

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I ran the full test suite before pushing the changes and all the tests pass.

@david-zw-liu david-zw-liu changed the title retrieve file after store Retrieve file after store Mar 25, 2022
revis0r
revis0r approved these changes Apr 5, 2022
View reviewed changes
Copy link

@revis0r revis0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it on my projects and it works great! Thanks!

@const-cloudinary const-cloudinary merged commit a55748c into cloudinary:master Apr 5, 2022
@const-cloudinary
Copy link
Contributor

@david-liu-950627 , thank you for contribution!

@david-zw-liu david-zw-liu mentioned this pull request Jun 13, 2022
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@revis0r revis0r revis0r approved these changes

@const-cloudinary const-cloudinary Awaiting requested review from const-cloudinary

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@david-zw-liu @const-cloudinary @revis0r