Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix obtaining identifier on rails >= 6.1 #493

Merged
merged 2 commits into from
Jul 14, 2022
Merged

Fix obtaining identifier on rails >= 6.1 #493

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36b95c8
change to use the public method `read_attribute` to obtain the identi…
Jun 13, 2022
a984070
fix spec filename
Jun 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/cloudinary/carrier_wave/process.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ def store!(new_file=nil)
super

column = model.send(:_mounter, mounted_as).send(:serialization_column)
identifier = model.send(:attribute, column)
identifier = model.read_attribute(column)
retrieve_from_store!(identifier) unless identifier.nil?
end
end
2 changes: 1 addition & 1 deletion spec/carriewave.rb → spec/carriewave_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ class SanitizedFile; end
subject { uploader.store! }

it 'triggers `#retrieve_from_store!` after `#store!` executed to populate @file and @identifier' do
expect(model).to receive(:attribute).with(column).and_return(identifier)
expect(model).to receive(:read_attribute).with(column).and_return(identifier)
expect(uploader).to receive(:retrieve_from_store!).with(identifier)

subject
Expand Down