fixed responsive issue on minicart and search suggestion #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuval-cloudinary
requested changes
Sep 19, 2024
| const config = { childList: true, subtree: true }; | ||
|
|
||
| const callback = function () { | ||
| if (targetNode.innerHTML.length > 0) { |
There was a problem hiding this comment.
please merge consecutive if statements
| @@ -2,12 +2,18 @@ | |||
|
|
|||
| module.exports = function () { | |||
| // Custom Start: Make cart product images responsive // | |||
There was a problem hiding this comment.
is it possible that the minicart would be called twice, and we will create duplicate observers?
Maybe it makes sense to use a global DOM variable to skip a second call to the minicart
There was a problem hiding this comment.
It only call once.
| } | ||
| }; | ||
|
|
||
| const observer = new MutationObserver(callback); |
There was a problem hiding this comment.
MutationObserver - I like it!
yuval-cloudinary
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.