Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the latest video player #1006

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Use the latest video player #1006

wants to merge 2 commits into from

Conversation

pereirinha
Copy link
Member

Update the video player

@pereirinha pereirinha marked this pull request as ready for review December 20, 2024 16:08
tharsheblows
tharsheblows reviewed Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@tharsheblows tharsheblows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are styles and scripts which use this as a version string which means that it will update without changing those and it could pick up cached versions inconsistently. Should those be updated also or maybe that's a reason to hold it to a given version?

@pereirinha
Copy link
Member Author

Excellent point @tharsheblows

tharsheblows
tharsheblows approved these changes Dec 30, 2024
View reviewed changes
Copy link
Collaborator

@tharsheblows tharsheblows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tharsheblows tharsheblows tharsheblows approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pereirinha @tharsheblows