Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix post save #986

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from
Draft

Fix post save #986

wants to merge 4 commits into from

Conversation

pereirinha
Copy link
Member

No description provided.

@cld-sec
Copy link

cld-sec commented Oct 11, 2024 •
edited
Loading

🎉 Snyk hasn't found any issues so far.

✅ security/snyk check is completed. No issues were found. (View Details)

✅ license/snyk check is completed. No issues were found. (View Details)

@tharsheblows
Copy link
Collaborator

This all looks good to me and reasonable! It's saving a post with no changes that triggers it? I guess it loses the edit context?

tharsheblows
tharsheblows previously approved these changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@tharsheblows tharsheblows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving this, it's straightforward and works to avoid trying to save the same content.

@tharsheblows tharsheblows dismissed their stale review October 16, 2024 21:27

Reviewed too early, still discussing

@pereirinha pereirinha mentioned this pull request Oct 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tharsheblows tharsheblows tharsheblows left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pereirinha @cld-sec @tharsheblows