Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove on form update hook #129

Merged
merged 2 commits into from
Feb 11, 2020
Merged

Conversation

maxime1992
Copy link
Contributor

@maxime1992 maxime1992 commented Jan 8, 2020

This closes #127

If you patch your form and update a few values, this hook will be called multiple times: 1 time for each updated value. Which is not ideal.

Also has a bug here #127

And I've given more details here: #86 (comment)
BREAKING CHANGE: `onFormUpdate` hook is now removed

This closes ngx-sub-form#127
@maxime1992 maxime1992 added effort-1: minutes Will only take a few minutes to fix/create flag: breaking change This feature or fix will require a breaking change PR-state: blocked This PR is currently blocked labels Jan 8, 2020
@maxime1992 maxime1992 requested a review from zakhenry January 8, 2020 18:47
@maxime1992 maxime1992 self-assigned this Jan 8, 2020
@maxime1992
Copy link
Contributor Author

This is a follow up of #128 to actually remove the hook.

⚠️ It contains a BREAKING CHANGE ⚠️

@maxime1992 maxime1992 changed the base branch from master to next February 11, 2020 11:30
@maxime1992 maxime1992 linked an issue Feb 11, 2020 that may be closed by this pull request
@maxime1992
Copy link
Contributor Author

@zakhenry once #128 is merged I think we should merge this one. I've changed the target branch to be next :)

@maxime1992 maxime1992 changed the title [DO NOT MERGE YET] remove on form update hook Remove on form update hook Feb 11, 2020
@maxime1992 maxime1992 merged commit 83ea41a into next Feb 11, 2020
@maxime1992 maxime1992 deleted the feat/remove-on-form-update-hook branch February 27, 2021 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort-1: minutes Will only take a few minutes to fix/create flag: breaking change This feature or fix will require a breaking change PR-state: blocked This PR is currently blocked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FormArray triggers onFormUpdate too early
2 participants