fix(Ivy): Fix TypedFormGroup<T> not being assignable to FormGroup #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Obsoleted by #139 (except maybe the test) |
|
@zakhenry I think that we should keep that one for the test but also add an extra check: Can you also set |
|
@maxime1992 there appears to be a tonne of issues, probably something to fix but not something to block this fix? |
fair enough 👍 Can you either create a follow up MR or an issue to keep track of this as it'd be nice to have? |
zakhenry
force-pushed
the
fix/ivy-compilation
branch
from
bd7b2aa
to
4381a42
Compare
|
@maxime1992 I've dropped the commit, and moved it to #146 |
maxime1992
reviewed
Feb 25, 2020
maxime1992
approved these changes
Feb 25, 2020
|
🎉 This PR is included in version 5.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #134