[WIP] fix: form array validation (for rewrite) #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxime1992
added
scope: lib
…t fine on the component itself but it's not propagating this error to the parent components on the same tick. It's fine after another CD though but unsure why we're missing 1 tick for now
maxime1992
force-pushed
the
fix/form-array-validation
branch
from
4808bfd
to
9762c87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #161 but unfortunately while it seems to be working just fine on the component hosting the FormArray, I've noticed that the error is not broadcasted up to the parent components.
Well, it actually is but one change detection cycle after :( And I'm unsure why.
I have a suspicion that it may be due to the fact that when the component is being initialised we're not re-sending the value up to the parent component which therefore doesn't call the
validatehook? Unsure as I haven't found the time to dig much more into it.I thought it'd be an easy fix but for now I want to get back on making sure we can release v6 asap and in order to do that we need to focus on the documentation 🙃.
If anyone wants to take a look why we're one tick too late please do 🙏 😸. Thanks!