Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ui): migrate ComboBox component to typescript #589

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

chore(ui): migrate ComboBox component to typescript #589

wants to merge 12 commits into from
+1,341 −28

Conversation

gjaskiewicz
Copy link
Contributor

Summary

Migrate combobox to TypeScript

Changes Made

  • Migrate Combobox to TypeScript
  • Migrate ComboboxOption to TypeScript

Related Issues

Testing Instructions

  1. npm i
  2. npm run storybook

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.

@gjaskiewicz gjaskiewicz requested review from franzheidl and a team as code owners November 6, 2024 10:28
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024 •
edited
Loading

PR Preview Action v1.4.8
🚀 Deployed preview to https://cloudoperators.github.io/juno/pr-preview/pr-589/
on branch gh-pages at 2024-11-13 19:53 UTC

@barsukov
Copy link
Contributor

barsukov commented Nov 6, 2024

You delete everything where is the changes? :) I mean if it is a draft or not finished please close the PR

@barsukov barsukov closed this Nov 6, 2024
@gjaskiewicz gjaskiewicz reopened this Nov 6, 2024
@gjaskiewicz
Copy link
Contributor Author

@barsukov @guoda-puidokaite can you take a look?

andypf
andypf previously approved these changes Nov 8, 2024
View reviewed changes
Copy link
Collaborator

@andypf andypf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

barsukov
barsukov requested changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@barsukov barsukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments from my side

packages/ui-components/src/components/ComboBoxOption/index.ts Outdated Show resolved Hide resolved
packages/ui-components/src/components/ComboBox/ComboBox.component.tsx Show resolved Hide resolved
packages/ui-components/src/components/ComboBox/ComboBox.stories.tsx Outdated Show resolved Hide resolved
packages/ui-components/src/components/ComboBox/ComboBox.stories.tsx Outdated Show resolved Hide resolved
packages/ui-components/src/components/ComboBox/ComboBox.stories.tsx Outdated Show resolved Hide resolved
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 8, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 10f6e9f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudoperators/juno-ui-components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

guoda-puidokaite
guoda-puidokaite reviewed Nov 8, 2024
View reviewed changes
Copy link
Contributor

@guoda-puidokaite guoda-puidokaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things from my side

packages/ui-components/src/components/ComboBox/ComboBox.component.tsx Outdated Show resolved Hide resolved
packages/ui-components/src/components/ComboBox/ComboBox.component.tsx Outdated Show resolved Hide resolved
packages/ui-components/src/components/ComboBoxOption/ComboBoxOption.component.tsx Outdated Show resolved Hide resolved
packages/ui-components/src/components/ComboBox/ComboBox.component.tsx Outdated Show resolved Hide resolved
guoda-puidokaite
guoda-puidokaite requested changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@guoda-puidokaite guoda-puidokaite left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Blocking)

Prettier issue in pipeline

@guoda-puidokaite guoda-puidokaite added ui-components All tasks related to juno-ui-components library package All tasks related to package under packages/ enhancement New feature or request labels Nov 11, 2024
@guoda-puidokaite guoda-puidokaite mentioned this pull request Nov 11, 2024
Open
23 tasks
barsukov
barsukov reviewed Nov 11, 2024
View reviewed changes
Copy link
Contributor

@barsukov barsukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also change index file, to return deprecated combobox cause it is still use a portal provider until we done with all related portal provider messages @guoda-puidokaite could you also check the warnings in console if it would be introduce here?

guoda-puidokaite
guoda-puidokaite requested changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@guoda-puidokaite guoda-puidokaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

packages/ui-components/src/components/ComboBox/ComboBox.stories.tsx Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barsukov barsukov barsukov requested changes

@franzheidl franzheidl Awaiting requested review from franzheidl franzheidl is a code owner

@guoda-puidokaite guoda-puidokaite Awaiting requested review from guoda-puidokaite

@andypf andypf Awaiting requested review from andypf

Requested changes must be addressed to merge this pull request.

Assignees

@gjaskiewicz gjaskiewicz

Labels
enhancement New feature or request Migration package All tasks related to package under packages/ ui-components All tasks related to juno-ui-components library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gjaskiewicz @barsukov @andypf @guoda-puidokaite