Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ui): migrate Grid, GridColumn and GridRow components to Typescript #595

Merged
merged 6 commits into from
Nov 7, 2024
Merged

chore(ui): migrate Grid, GridColumn and GridRow components to Typescript #595

merged 6 commits into from
Nov 7, 2024

Conversation

guoda-puidokaite
Copy link
Contributor

@guoda-puidokaite guoda-puidokaite commented Nov 6, 2024 •
edited
Loading

Summary

  • Migrated the Grid, GridColumn and GridRow components to TypeScript, enhancing code quality, maintainability, and scalability.
  • Utilised static typing to minimize runtime errors and improve the development experience.
  • Removed deprecated Grid, GridColumn and GridRow .js components
  • Refactored the component for cleaner, more maintainable code.

Changes Made

TypeScript Migration:

  • Converted Grid, GridColumn and GridRow component files to TypeScript.
  • Added comprehensive type annotations.

Cleanup:

  • Removed deprecated code. It wasn't needed for any .js components.

Refactoring:

  • Made necessary adjustments to address TypeScript-detected issues.
  • Further refactored for cleaner and more understandable code.

Testing:

  • Added edge case tests: 28dc6be
  • Organised tests by what they check for better readability and maintenance.
  • Verified component behaviour using Storybook.
  • Updated tests to use vitest.

Documentation:

  • Updated Storybook documentation.

Release:

  • Generated a changeset file.

Related Issues

Testing Instructions

  • Check deployedStorybook

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 6, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 90e50eb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudoperators/juno-ui-components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@guoda-puidokaite guoda-puidokaite self-assigned this Nov 6, 2024
@guoda-puidokaite guoda-puidokaite added enhancement New feature or request package All tasks related to package under packages/ ui-components All tasks related to juno-ui-components library refactor labels Nov 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024 •
edited
Loading

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-11-07 16:10 UTC

@guoda-puidokaite guoda-puidokaite marked this pull request as ready for review November 6, 2024 22:15
@guoda-puidokaite guoda-puidokaite linked an issue Nov 6, 2024 that may be closed by this pull request
[TASK](ui): Migrate Grid(All related) component to TypeScript #229
Closed
6 tasks
TilmanHaupt
TilmanHaupt approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@TilmanHaupt TilmanHaupt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

barsukov
barsukov approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@barsukov barsukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HERE WE GO

packages/ui-components/src/components/Grid/Grid.component.tsx Show resolved Hide resolved
andypf
andypf approved these changes Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@andypf andypf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andypf andypf merged commit 63a951c into main Nov 7, 2024
15 checks passed
@andypf andypf deleted the guoda-convert-grid-to-ts branch November 7, 2024 16:10
@guoda-puidokaite guoda-puidokaite mentioned this pull request Nov 8, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TilmanHaupt TilmanHaupt TilmanHaupt approved these changes

@andypf andypf andypf approved these changes

@barsukov barsukov barsukov approved these changes

@franzheidl franzheidl Awaiting requested review from franzheidl franzheidl is a code owner

Assignees

@guoda-puidokaite guoda-puidokaite

Labels
enhancement New feature or request package All tasks related to package under packages/ refactor ui-components All tasks related to juno-ui-components library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TASK](ui): Migrate Grid(All related) component to TypeScript
4 participants
@guoda-puidokaite @barsukov @andypf @TilmanHaupt