Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(supernova): activeFilters are not rendered if value is not an array #610

Merged
merged 9 commits into from
Nov 14, 2024
Merged

fix(supernova): activeFilters are not rendered if value is not an array #610

merged 9 commits into from
Nov 14, 2024
+79 −4

Conversation

TilmanHaupt
Copy link
Contributor

@TilmanHaupt TilmanHaupt commented Nov 14, 2024 •
edited
Loading

Summary

Fix issue where activeFilters are not rendered if the value is not an array. Closes #609

Testing Instructions

  1. npm i
  2. npm run TASK

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • [] I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • [] I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.

@TilmanHaupt TilmanHaupt requested a review from a team as a code owner November 14, 2024 11:52
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 14, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 627c60a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudoperators/juno-app-supernova Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 14, 2024 •
edited
Loading

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-11-14 13:35 UTC

guoda-puidokaite
guoda-puidokaite reviewed Nov 14, 2024
View reviewed changes
Copy link
Contributor

@guoda-puidokaite guoda-puidokaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, just slight suggestion.

apps/supernova/src/components/filters/FilterPills.jsx Outdated Show resolved Hide resolved
guoda-puidokaite
guoda-puidokaite previously requested changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@guoda-puidokaite guoda-puidokaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a unit test to cover this bug for the future?

@ArtieReus ArtieReus mentioned this pull request Nov 14, 2024
Open
3 tasks
@ArtieReus
Copy link
Collaborator

ArtieReus commented Nov 14, 2024 •
edited
Loading

Could we add a unit test to cover this bug for the future?

The tests are being done on the object itself to run. We had already some but not enough:
https://github.com/cloudoperators/juno/pull/610/files#diff-3ef6e96df976fa40198f9b23b7a2855e7c30191104339fae3908d95b3267d8d3

ArtieReus
ArtieReus reviewed Nov 14, 2024
View reviewed changes
Copy link
Collaborator

@ArtieReus ArtieReus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider Goudes code improvements. Thx

ArtieReus
ArtieReus previously approved these changes Nov 14, 2024
View reviewed changes
Copy link
Collaborator

@ArtieReus ArtieReus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

hodanoori
hodanoori previously approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@hodanoori hodanoori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ArtieReus
ArtieReus approved these changes Nov 14, 2024
View reviewed changes
Copy link
Collaborator

@ArtieReus ArtieReus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

.changeset/clean-plums-notice.md Outdated Show resolved Hide resolved
@ArtieReus ArtieReus added the supernova All tasks related to supernova label Nov 14, 2024
andypf
andypf approved these changes Nov 14, 2024
View reviewed changes
Copy link
Collaborator

@andypf andypf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

.changeset/clean-plums-notice.md Outdated Show resolved Hide resolved
@TilmanHaupt TilmanHaupt merged commit 879812b into main Nov 14, 2024
15 checks passed
@TilmanHaupt TilmanHaupt deleted the til-fix-inital branch November 14, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guoda-puidokaite guoda-puidokaite guoda-puidokaite left review comments

@ArtieReus ArtieReus ArtieReus approved these changes

@andypf andypf andypf approved these changes

@hodanoori hodanoori hodanoori left review comments

Assignees

@TilmanHaupt TilmanHaupt

Labels
supernova All tasks related to supernova
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG](supernova): Non array values in FilterPills lead to failed render
5 participants
@TilmanHaupt @ArtieReus @andypf @hodanoori @guoda-puidokaite