Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): do not use relative asset paths in prod builds #613

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

andypf
Copy link
Collaborator

@andypf andypf commented Nov 14, 2024

Summary

This PR removes the base option from vite.config.js in all apps to prevent building relative paths for assets in production. To maintain support for previews deployed under a specific path, the base option is now configured directly in the preview workflow.

Changes Made

  • remove base option from all vite configs
  • add baseoption to build-asset.sh

Testing Instructions

  1. npm i
  2. npm run TASK

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.

@andypf andypf requested a review from a team as a code owner November 14, 2024 13:42
@andypf andypf changed the title Andypf ci improvements chore(ci): do not use relative asset paths in prod builds Nov 14, 2024
Copy link

changeset-bot bot commented Nov 14, 2024

⚠️ No Changeset found

Latest commit: 9e2e340

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 14, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://cloudoperators.github.io/juno/pr-preview/pr-613/
on branch gh-pages at 2024-11-14 15:41 UTC

@andypf andypf self-assigned this Nov 14, 2024
@andypf andypf added enhancement New feature or request infrastructure Infrastructure related issues, ci as well labels Nov 14, 2024
Copy link
Collaborator

@ArtieReus ArtieReus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@hodanoori hodanoori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request infrastructure Infrastructure related issues, ci as well
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants