Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce Output in Atmos Tests #923

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Reduce Output in Atmos Tests #923

wants to merge 20 commits into from
+202 −30

Conversation

Cerebrovinny
Copy link
Collaborator

@Cerebrovinny Cerebrovinny commented Jan 9, 2025 •
edited
Loading

what

  • Introduced verbosity levels. Allows customizable detail.
  • Updated GitHub Actions: Modified test execution. Added verbosity control.
  • Improved Logging: Validated logs-level flag. Ensures correct log levels.
  • Updated README: Documented test verbosity. Guides on usage.

why

  • Reduces redundant output.
  • CI/CD: Provides clearer feedback

references

@mergify mergify bot added the triage Needs triage label Jan 9, 2025
@osterman osterman added the no-release Do not create a new release (wait for additional code changes) label Jan 10, 2025
@mergify Mergify
Copy link

mergify bot commented Jan 10, 2025

Important

Cloud Posse Engineering Team Review Required

This pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes.

To expedite this process, reach out to us on Slack in the #pr-reviews channel.

@mergify mergify bot added the needs-cloudposse Needs Cloud Posse assistance label Jan 10, 2025
@mergify mergify bot removed needs-cloudposse Needs Cloud Posse assistance triage Needs triage labels Jan 10, 2025
@Cerebrovinny Cerebrovinny reopened this Jan 10, 2025
@mergify Mergify
Copy link

mergify bot commented Jan 10, 2025

Important

Cloud Posse Engineering Team Review Required

This pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes.

To expedite this process, reach out to us on Slack in the #pr-reviews channel.

@mergify mergify bot added the needs-cloudposse Needs Cloud Posse assistance label Jan 10, 2025
@Cerebrovinny Cerebrovinny force-pushed the DEV-2909 branch 3 times, most recently from 414bb4a to 28e8c98 Compare January 13, 2025 23:26
@Cerebrovinny Cerebrovinny marked this pull request as ready for review January 14, 2025 11:47
@Cerebrovinny Cerebrovinny requested review from a team as code owners January 14, 2025 11:47
osterman
osterman reviewed Jan 14, 2025
View reviewed changes
.github/workflows/test.yml Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a lot of tests were unintentionally deleted from this file.

Copy link
Collaborator Author

@Cerebrovinny Cerebrovinny Jan 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did that to test the output of robherley/go-test-action@v0 in actions, its added back

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw this is not very good, not able to make it work properly so for now I recommend we stick with our main tests only

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"this is not very good"

Not sure what it refers to.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think by default it runs go test, so its somehow overwriting my quiet config, I not totally sure but this is up to you I can continue investigating if you want to implement it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Cerebrovinny can you provide more details on the issue and how do you think it can be solved

tests/cli_test.go Outdated Show resolved Hide resolved
@Cerebrovinny Cerebrovinny requested a review from aknysh January 14, 2025 12:59
osterman
osterman reviewed Jan 14, 2025
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@Cerebrovinny Cerebrovinny requested a review from osterman January 16, 2025 12:31
coderabbitai[bot]
coderabbitai bot previously approved these changes Jan 16, 2025
View reviewed changes
osterman
osterman reviewed Jan 16, 2025
View reviewed changes
README.md Outdated Show resolved Hide resolved
@Cerebrovinny Cerebrovinny requested a review from osterman January 16, 2025 13:32
@aknysh
Copy link
Member

aknysh commented Jan 18, 2025

@Cerebrovinny please resolve the conflicts
Does this PR have unresolved conversations or comments that you think need to be addressed?

@mergify Mergify
Copy link

mergify bot commented Jan 20, 2025

💥 This pull request now has conflicts. Could you fix it @Cerebrovinny? 🙏

@mergify mergify bot added the conflict This PR has conflicts label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

@aknysh aknysh Awaiting requested review from aknysh

@osterman osterman Awaiting requested review from osterman

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
conflict This PR has conflicts needs-cloudposse Needs Cloud Posse assistance no-release Do not create a new release (wait for additional code changes)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Cerebrovinny @aknysh @osterman