Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix custom origin, add s3 origin for error pages #95

Closed
wants to merge 3 commits into from
Closed

Fix custom origin, add s3 origin for error pages #95

wants to merge 3 commits into from

Conversation

abondi-xplor
Copy link

what

  • custom origins can be created without error for using s3_origin_config
  • add the ability to add an s3 origin for use in routing traffic to error pages/custom error responses

why

  • custom origins do not work with the current version of this module
  • allows a custom origin with s3 to be used as a secondary origin for error handling

references

@abondi-xplor abondi-xplor requested review from a team as code owners March 15, 2023 21:31
@hans-d hans-d closed this Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamengual jamengual Awaiting requested review from jamengual jamengual is a code owner automatically assigned from cloudposse/contributors

@joe-niland joe-niland Awaiting requested review from joe-niland joe-niland is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abondi-xplor @hans-d @joe-niland