Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[eks/actions-runner-controller]: support Runner Group, webhook queue size #621

Merged
merged 5 commits into from
Apr 5, 2023
Merged

[eks/actions-runner-controller]: support Runner Group, webhook queue size #621

merged 5 commits into from
Apr 5, 2023

Conversation

Nuru
Copy link
Contributor

@Nuru Nuru commented Apr 4, 2023 •
edited
Loading

what

  • eks/actions-runner-controller
    • Support Runner Groups
    • Enable configuration of the webhook queue size limit
    • Change runner controller Docker image designation
  • Add documentation on Runner Groups and Autoscaler configuration

why

  • Enable separate access control to self-hosted runners
  • For users that launch a large number of jobs in a short period of time, allow bigger queues to avoid losing jobs
  • Maintainers recommend new tag format. ghcr.io has better rate limits than docker.io.

references

@Nuru Nuru requested review from a team as code owners April 4, 2023 03:26
@Nuru Nuru requested a review from aknysh April 4, 2023 22:50
aknysh
aknysh reviewed Apr 5, 2023
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see comments

@Nuru Nuru requested a review from aknysh April 5, 2023 20:20
@Nuru Nuru merged commit 79103c8 into master Apr 5, 2023
@Nuru Nuru deleted the gha-runner-groups branch April 5, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh approved these changes

@max-lobur max-lobur Awaiting requested review from max-lobur

@nitrocode nitrocode Awaiting requested review from nitrocode

@milldr milldr Awaiting requested review from milldr

@Benbentwo Benbentwo Awaiting requested review from Benbentwo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nuru @aknysh @dudymas