feat: Add tags to aws_appautoscaling_target #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tags introduced for all `aws_appautoscaling_target` resources created after 2023-03-20
|
/terratest |
aknysh
added
minor
|
These changes were released in v0.1.0. |
MaxymVlasov
added a commit
to MaxymVlasov/terraform-aws-dynamodb
that referenced
this pull request
Aug 6, 2024
Update `terraform-aws-dynamodb-autoscaler` module to set tags for `aws_appautoscaling_target` resources Related PR: cloudposse/terraform-aws-dynamodb-autoscaler#65
This was referenced Aug 6, 2024
aknysh
pushed a commit
to cloudposse/terraform-aws-dynamodb
that referenced
this pull request
Aug 6, 2024
* feat: Add tags to aws_appautoscaling_target Update `terraform-aws-dynamodb-autoscaler` module to set tags for `aws_appautoscaling_target` resources Related PR: cloudposse/terraform-aws-dynamodb-autoscaler#65 * Update main.tf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Add missed tags
why
Tags were introduced for all
aws_appautoscaling_targetresources created after 2023-03-20.That blocks us from enforcing policy checks for missing tags.
references
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/appautoscaling_target
Also, after release a new version here, we need release in https://github.com/cloudposse/terraform-aws-dynamodb/blob/a0cfac2e8c2584125596089a3185fc4a057410e4/main.tf#L153-L155