fix: hide navigation button when toolbar variant of AppLayout has hideNavigation #11933
build-lint-test.yml
on: pull_request
build
/
git-secrets
6s
build
/
build
7m 48s
build
/
codeql
2m 42s
git-secrets
8s
deploy
/
deploy
Annotations
2 errors and 11 warnings
mergeMultiAppLayoutProps › should merge ownProps and additionalProps correctly:
src/app-layout/__tests__/multi-layout.test.tsx#L118
expect(received).toEqual(expected) // deep equality
- Expected - 4
+ Received + 4
@@ -1,20 +1,20 @@
Object {
- "activeDrawerId": "drawer2",
+ "activeDrawerId": "drawer1",
"ariaLabels": Object {
"drawers": "Drawers",
"navigation": "New Navigation",
},
"drawers": Array [
Object {
"ariaLabels": Object {
- "drawerName": "Drawer 2",
+ "drawerName": "Drawer 1",
},
"content": <div>
- Drawer 2 Content
+ Drawer 1 Content
</div>,
- "id": "drawer2",
+ "id": "drawer1",
},
],
"drawersFocusRef": Object {
"current": null,
},
at Object.<anonymous> (src/app-layout/__tests__/multi-layout.test.tsx:118:20)
|
build / build
Process completed with exit code 1.
|
build / build
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
build / build:
pages/button/alignment.page.tsx#L25
Unexpected 'todo' comment: 'TODO: uncomment when we add...'
|
build / build:
pages/form-field/form-field-columns.page.tsx#L20
Unexpected 'todo' comment: 'TODO: Replace this with Select'
|
build / build:
pages/utils/permutations-view.tsx#L18
Unexpected 'todo' comment: 'TODO: Pretty-print original JSX,...'
|
build / build:
src/__a11y__/to-validate-a11y.ts#L76
Unexpected 'todo' comment: 'TODO: remove polyfill with es2019...'
|
build / build:
src/app-layout/__integ__/app-layout-drawers.test.ts#L224
Unexpected 'todo' comment: 'todo: resolve split panel positioning...'
|
build / build:
src/app-layout/__integ__/app-layout-focus-delegation.test.ts#L182
Unexpected 'todo' comment: 'todo - investigate why resize observer...'
|
build / build:
src/app-layout/__tests__/main.test.tsx#L57
Unexpected 'todo' comment: 'TODO: enable after fixing 'tools...'
|
build / build:
src/app-layout/__tests__/main.test.tsx#L136
Unexpected 'todo' comment: 'TODO Enable after fixing...'
|
build / build:
src/app-layout/__tests__/main.test.tsx#L147
Unexpected 'todo' comment: 'TODO Enable after fixing 'Distinguish...'
|
build / build:
src/app-layout/visual-refresh-toolbar/toolbar/index.tsx#L119
Unexpected 'todo' comment: 'TODO: expose configuration property'
|