Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow Cards selection by clicking anywhere on the card with entireCardClickable property #1670

Merged
merged 5 commits into from
Nov 2, 2023

Conversation

timogasda
Copy link
Member

@timogasda timogasda commented Oct 18, 2023

Description

This change introduces a new property for Cards that allows the entire card to be clickable to make a selection. This is helpful when selection is a main use-case for this instance of Cards, and there are no other interactive elements in the cards sections.

Related links, issue #, if available: AWSUI-14894, InohAwVWe3aI

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (349421b) 94.32% compared to head (ec2988c) 94.33%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1670   +/-   ##
=======================================
  Coverage   94.32%   94.33%           
=======================================
  Files         651      651           
  Lines       17566    17572    +6     
  Branches     5778     5783    +5     
=======================================
+ Hits        16570    16576    +6     
  Misses        928      928           
  Partials       68       68           
Files Coverage Δ
src/cards/index.tsx 94.38% <100.00%> (+0.40%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timogasda timogasda changed the title wip: POC of clickable cards feat: Allow Cards selection by clicking anywhere on the card Nov 1, 2023
@timogasda timogasda marked this pull request as ready for review November 2, 2023 08:14
@timogasda timogasda requested a review from a team as a code owner November 2, 2023 08:14
@timogasda timogasda requested review from Al-Dani and removed request for a team November 2, 2023 08:14
pan-kot
pan-kot previously approved these changes Nov 2, 2023
Al-Dani
Al-Dani previously approved these changes Nov 2, 2023
@timogasda timogasda dismissed stale reviews from Al-Dani and pan-kot via ec2988c November 2, 2023 15:43
@timogasda timogasda changed the title feat: Allow Cards selection by clicking anywhere on the card feat: Allow Cards selection by clicking anywhere on the card with entireCardClickable property Nov 2, 2023
@timogasda timogasda merged commit fe1028b into main Nov 2, 2023
34 checks passed
@timogasda timogasda deleted the gasda/clickable-cards branch November 2, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants