-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow Cards selection by clicking anywhere on the card with entireCardClickable
property
#1670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1670 +/- ##
=======================================
Coverage 94.32% 94.33%
=======================================
Files 651 651
Lines 17566 17572 +6
Branches 5778 5783 +5
=======================================
+ Hits 16570 16576 +6
Misses 928 928
Partials 68 68
☔ View full report in Codecov by Sentry. |
timogasda
changed the title
wip: POC of clickable cards
feat: Allow Cards selection by clicking anywhere on the card
Nov 1, 2023
pan-kot
previously approved these changes
Nov 2, 2023
Al-Dani
previously approved these changes
Nov 2, 2023
timogasda
force-pushed
the
gasda/clickable-cards
branch
from
November 2, 2023 15:43
cd17ad9
to
ec2988c
Compare
timogasda
changed the title
feat: Allow Cards selection by clicking anywhere on the card
feat: Allow Cards selection by clicking anywhere on the card with Nov 2, 2023
entireCardClickable
property
Al-Dani
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change introduces a new property for Cards that allows the entire card to be clickable to make a selection. This is helpful when selection is a main use-case for this instance of Cards, and there are no other interactive elements in the cards sections.
Related links, issue #, if available: AWSUI-14894,
InohAwVWe3aI
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md
.CONTRIBUTING.md
.Security
checkSafeUrl
function.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.