Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update padding for button dropdown with main action #1673

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

timogasda
Copy link
Member

Description

The padding for the button dropdown with main action looked a little bit unbalanced. This change fixes that problem.

Related links, issue #, if available: AWSUI-22498

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@timogasda timogasda requested a review from a team as a code owner October 18, 2023 14:22
@timogasda timogasda requested review from YueyingLu and removed request for a team October 18, 2023 14:22
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (7fa1db8) 94.19% compared to head (d2841f3) 94.19%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1673   +/-   ##
=======================================
  Coverage   94.19%   94.19%           
=======================================
  Files         650      650           
  Lines       17530    17530           
  Branches     5771     5771           
=======================================
  Hits        16513    16513           
  Misses        948      948           
  Partials       69       69           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timogasda timogasda merged commit f36394d into main Oct 19, 2023
30 of 31 checks passed
@timogasda timogasda deleted the gasda/split-button-dropdown-padding branch October 19, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants