chore: Add integ tests for multi page create funnel metrics #1695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1695 +/- ##
=======================================
Coverage 94.19% 94.20%
=======================================
Files 650 650
Lines 17539 17539
Branches 5775 5775
=======================================
+ Hits 16521 16522 +1
+ Misses 949 948 -1
Partials 69 69 ☔ View full report in Codecov by Sentry. |
michaeldowseza
force-pushed
the
analytics/integ-tests-multi-page
branch
from
52bbca4
to
10950df
Compare
michaeldowseza
changed the title
michaeldowseza
requested review from
rubencarvalho
and removed request for
a team
connorlanigan
approved these changes
Oct 27, 2023
| const { funnelLog, actions } = await page.getFunnelLog(); | ||
| expect(actions).toEqual(['funnelStart', 'funnelStepStart']); | ||
|
|
||
| const [funnelStartEvent, funnelStartStepEvent] = funnelLog; |
There was a problem hiding this comment.
minor: we could rename "funnelStartStepEvent" to "funnelStepStartEvent" to align with the event name
There was a problem hiding this comment.
Will follow up with a fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Similar to this PR to add for integ tests for single page.
This adds tests for the existing behaviour. It includes some fix mes that were found while writing and is intended as a start to testing.
Related links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.