Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Migrate "G/H/I/J/K/L/M" components to logical properties #1792

Merged
merged 5 commits into from
Feb 7, 2024

Conversation

DaemonCahill
Copy link
Member

@DaemonCahill DaemonCahill commented Dec 7, 2023

This PR is a subset of the changes drafted in #1713 that affect only the subset of components that being with the letters "G/H/I/J/K/L/M".

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2878ee9) 94.78% compared to head (2e6bafb) 94.79%.

❗ Current head 2e6bafb differs from pull request most recent head de6a230. Consider uploading reports for the commit de6a230 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1792   +/-   ##
=======================================
  Coverage   94.78%   94.79%           
=======================================
  Files         662      662           
  Lines       17932    17932           
  Branches     5923     5923           
=======================================
+ Hits        16997    16998    +1     
+ Misses        870      869    -1     
  Partials       65       65           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DaemonCahill DaemonCahill changed the title chore: Migrate "G/H/I/J/K/LM" components to logical properties chore: Migrate "G/H/I/J/K/L/M" components to logical properties Dec 7, 2023
@DaemonCahill DaemonCahill force-pushed the scottob-logical-properties-ghijklm branch from 8c6cc8a to beeabfc Compare December 8, 2023 18:35
@DaemonCahill DaemonCahill force-pushed the scottob-logical-properties-ghijklm branch from beeabfc to ccd493e Compare December 11, 2023 15:04
@DaemonCahill DaemonCahill marked this pull request as ready for review December 11, 2023 15:06
@DaemonCahill DaemonCahill requested a review from a team as a code owner December 11, 2023 15:06
@DaemonCahill DaemonCahill requested review from Al-Dani and removed request for a team December 11, 2023 15:06
@DaemonCahill DaemonCahill force-pushed the scottob-logical-properties-ghijklm branch from ccd493e to 00583b0 Compare December 12, 2023 17:40
@DaemonCahill DaemonCahill force-pushed the scottob-logical-properties-ghijklm branch from 00583b0 to c4baf49 Compare January 3, 2024 21:23
@DaemonCahill DaemonCahill force-pushed the scottob-logical-properties-ghijklm branch from c4baf49 to e64e708 Compare January 21, 2024 19:09
@DaemonCahill DaemonCahill force-pushed the scottob-logical-properties-ghijklm branch from e64e708 to 84310be Compare January 26, 2024 19:31
@DaemonCahill DaemonCahill force-pushed the scottob-logical-properties-ghijklm branch from 84310be to f286e76 Compare January 29, 2024 15:51
@DaemonCahill DaemonCahill force-pushed the scottob-logical-properties-ghijklm branch from f286e76 to a011f57 Compare February 5, 2024 21:43
@DaemonCahill DaemonCahill temporarily deployed to visual-regression-report February 6, 2024 18:32 — with GitHub Actions Inactive
Al-Dani
Al-Dani previously approved these changes Feb 6, 2024
@DaemonCahill DaemonCahill merged commit ff5efc1 into main Feb 7, 2024
58 checks passed
@DaemonCahill DaemonCahill deleted the scottob-logical-properties-ghijklm branch February 7, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants