Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Migrate "A/B/C/D/E/F" components to logical properties #1851

Merged
merged 18 commits into from
Feb 12, 2024

Conversation

DaemonCahill
Copy link
Member

This PR is a subset of the changes drafted in #1713 that affect only the subset of components that being with the letters "A/B/C/D/E/F".

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a086982) 94.75% compared to head (6fcdc00) 94.74%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1851      +/-   ##
==========================================
- Coverage   94.75%   94.74%   -0.01%     
==========================================
  Files         661      661              
  Lines       17989    17989              
  Branches     5950     5950              
==========================================
- Hits        17045    17044       -1     
- Misses        879      880       +1     
  Partials       65       65              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rubencarvalho
rubencarvalho previously approved these changes Jan 11, 2024
@DaemonCahill DaemonCahill force-pushed the scottob-logical-properties-abcdef branch from e389b38 to 4cc7e13 Compare January 21, 2024 17:20
@DaemonCahill DaemonCahill force-pushed the scottob-logical-properties-abcdef branch from 4cc7e13 to 004d192 Compare January 26, 2024 19:31
@DaemonCahill DaemonCahill force-pushed the scottob-logical-properties-abcdef branch from 3fc45ee to c8f2f06 Compare January 29, 2024 15:51
@DaemonCahill DaemonCahill force-pushed the scottob-logical-properties-abcdef branch from c8f2f06 to e6207fc Compare February 5, 2024 21:44
@just-boris just-boris requested review from a team and removed request for rubencarvalho February 6, 2024 14:48
just-boris
just-boris previously approved these changes Feb 12, 2024
src/calendar/styles.scss Outdated Show resolved Hide resolved
@@ -12,10 +12,10 @@

.code-editor-refresh :global .ace_editor {
.ace_gutter {
border-top-left-radius: calc(awsui.$border-radius-code-editor - awsui.$border-item-width);
border-start-start-radius: calc(awsui.$border-radius-code-editor - awsui.$border-item-width);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants