-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Migrate "A/B/C/D/E/F" components to logical properties #1851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1851 +/- ##
==========================================
- Coverage 94.75% 94.74% -0.01%
==========================================
Files 661 661
Lines 17989 17989
Branches 5950 5950
==========================================
- Hits 17045 17044 -1
- Misses 879 880 +1
Partials 65 65 ☔ View full report in Codecov by Sentry. |
DaemonCahill
force-pushed
the
scottob-logical-properties-abcdef
branch
from
January 3, 2024 17:42
d137a2f
to
a6f3319
Compare
DaemonCahill
requested review from
rubencarvalho
and removed request for
a team
January 3, 2024 21:27
rubencarvalho
previously approved these changes
Jan 11, 2024
DaemonCahill
force-pushed
the
scottob-logical-properties-abcdef
branch
from
January 21, 2024 17:20
e389b38
to
4cc7e13
Compare
DaemonCahill
force-pushed
the
scottob-logical-properties-abcdef
branch
from
January 26, 2024 19:31
4cc7e13
to
004d192
Compare
DaemonCahill
force-pushed
the
scottob-logical-properties-abcdef
branch
from
January 29, 2024 15:51
3fc45ee
to
c8f2f06
Compare
DaemonCahill
force-pushed
the
scottob-logical-properties-abcdef
branch
from
February 5, 2024 21:44
c8f2f06
to
e6207fc
Compare
just-boris
requested review from
a team
and removed request for
rubencarvalho
February 6, 2024 14:48
DaemonCahill
force-pushed
the
scottob-logical-properties-abcdef
branch
from
February 12, 2024 13:50
06bfe9a
to
c3285cd
Compare
just-boris
previously approved these changes
Feb 12, 2024
@@ -12,10 +12,10 @@ | |||
|
|||
.code-editor-refresh :global .ace_editor { | |||
.ace_gutter { | |||
border-top-left-radius: calc(awsui.$border-radius-code-editor - awsui.$border-item-width); | |||
border-start-start-radius: calc(awsui.$border-radius-code-editor - awsui.$border-item-width); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
just-boris
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a subset of the changes drafted in #1713 that affect only the subset of components that being with the letters "A/B/C/D/E/F".