Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add loading a11y to s3 selectors for screen readers #2475

Merged

Conversation

orangevolon
Copy link
Contributor

@orangevolon orangevolon commented Jul 17, 2024

Description

Adds Last Updated to the S3 resource selector modal.
The addition of this text should help the screen readers to inform the users once the fetch process is finished.

Related links, issue #, if available: AWSUI-41521

How has this been tested?

Manually tested on Chrome, Firefox & Safari.
Automated testing in progress.

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@orangevolon orangevolon force-pushed the feat/add-loading-a11y-to-s3-selectors-for-screen-readers branch 2 times, most recently from 4aa8453 to 47eb27c Compare July 19, 2024 08:40
@orangevolon orangevolon changed the title Feat/add loading a11y to s3 selectors for screen readers feat: add loading a11y to s3 selectors for screen readers Jul 19, 2024
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.80%. Comparing base (d7217eb) to head (f82ac50).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2475      +/-   ##
==========================================
- Coverage   95.80%   95.80%   -0.01%     
==========================================
  Files         728      728              
  Lines       19874    19886      +12     
  Branches     6700     6745      +45     
==========================================
+ Hits        19040    19051      +11     
- Misses        779      827      +48     
+ Partials       55        8      -47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orangevolon orangevolon force-pushed the feat/add-loading-a11y-to-s3-selectors-for-screen-readers branch 2 times, most recently from 8bd178a to c54cc6c Compare July 19, 2024 14:40
@orangevolon orangevolon force-pushed the feat/add-loading-a11y-to-s3-selectors-for-screen-readers branch from c54cc6c to 3b3b8c7 Compare July 24, 2024 12:56
@orangevolon orangevolon force-pushed the feat/add-loading-a11y-to-s3-selectors-for-screen-readers branch from 3b3b8c7 to 8dcb8c8 Compare July 25, 2024 07:49
@orangevolon orangevolon force-pushed the feat/add-loading-a11y-to-s3-selectors-for-screen-readers branch 2 times, most recently from 9d5cc02 to 6dc8f95 Compare July 25, 2024 08:33
@orangevolon orangevolon marked this pull request as ready for review July 25, 2024 08:54
@orangevolon orangevolon requested a review from a team as a code owner July 25, 2024 08:54
@orangevolon orangevolon requested review from jperals and removed request for a team July 25, 2024 08:54
jperals
jperals previously approved these changes Jul 25, 2024
@avinashbot avinashbot self-requested a review July 25, 2024 10:53
return (
<InternalSpaceBetween size="s" direction="horizontal" alignItems="center">
{getLastUpdated()}
<InternalButton iconName="refresh" ariaLabel={i18nStrings.labelRefresh} onClick={reloadData} />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a random comment - it's crazy to me that we don't disable the reload button while a fetch is taking place. But at this point, I'm a little worried that switching it to a loading state is a breaking change, so... 😔

Copy link
Contributor Author

@orangevolon orangevolon Jul 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It certainly looks weird not receiving a feedback when clicking on the button. I think here the other parts of the "loading & refreshing" guideline also comes into play.

Cases for when it's loading, it's taking longer that usual or it's failing for some reason.
I think it makes sense to bucket them together, in another PR.

@orangevolon orangevolon merged commit 7dd5a98 into main Jul 29, 2024
42 checks passed
@orangevolon orangevolon deleted the feat/add-loading-a11y-to-s3-selectors-for-screen-readers branch July 29, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants