Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds property filter custom form actions test utils selectors #2840

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

pan-kot
Copy link
Member

@pan-kot pan-kot commented Oct 10, 2024

Description

Adding test util methods to find the Cancel and Submit buttons in the property filter custom form. The same methods are to be reused for multi-choice forms implemented here: #2739.

The new methods can be used as follows:

createWrapper().findPropertyFilter().findPropertyCancelButton().click()
createWrapper().findPropertyFilter().findPropertySubmitButton({ expandToViewport: true }).click()

That is similar to existing:

createWrapper().findPropertyFilter().findErrorRecoveryButton({ expandToViewport: true }).click()
Screenshot 2024-10-10 at 14 06 54

How has this been tested?

  • Updated existing unit tests
Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.19%. Comparing base (8977aef) to head (2788f4c).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2840      +/-   ##
==========================================
- Coverage   96.20%   96.19%   -0.01%     
==========================================
  Files         761      761              
  Lines       21430    21434       +4     
  Branches     7271     7324      +53     
==========================================
+ Hits        20616    20619       +3     
- Misses        761      762       +1     
  Partials       53       53              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pan-kot pan-kot marked this pull request as ready for review October 10, 2024 12:28
@pan-kot pan-kot requested a review from a team as a code owner October 10, 2024 12:28
@pan-kot pan-kot requested review from cansuaa and connorlanigan and removed request for a team October 10, 2024 12:28
@pan-kot pan-kot added this pull request to the merge queue Oct 11, 2024
Merged via the queue into main with commit 20be751 Oct 11, 2024
35 checks passed
@pan-kot pan-kot deleted the feat-property-filter-custom-form-test-util branch October 11, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants