fix: Runtime drawers default active #2870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 227dd63.
georgylobko
commented
Oct 15, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2870 +/- ##
==========================================
- Coverage 96.20% 96.20% -0.01%
==========================================
Files 762 761 -1
Lines 21488 21453 -35
Branches 7284 7280 -4
==========================================
- Hits 20673 20639 -34
+ Misses 762 761 -1
Partials 53 53 ☔ View full report in Codecov by Sentry. |
georgylobko
requested review from
jperals,
just-boris and
dpitcock
and removed request for
a team and
jperals
ajsuvarna6
reviewed
Oct 15, 2024
ajsuvarna6
reviewed
Oct 15, 2024
just-boris
reviewed
Oct 16, 2024
| @@ -1042,5 +1042,36 @@ describe('toolbar mode only features', () => { | |||
|
|
|||
| expect(wrapper.findActiveDrawer()!.getElement()).toHaveTextContent('runtime drawer content'); | |||
| }); | |||
|
|
|||
| test('dynamically registered drawers with defaultActive: true should open even when there are already open drawer(s) on the page', async () => { | |||
There was a problem hiding this comment.
Do we have negative case scenarios?
- After max drawers already open,
defaultActivedoes not open a new one - After user opened a global drawer manually, late registered
defaultActivedon't open
There was a problem hiding this comment.
No for both. Do we have any specific requirements for this? If so, could you point me to where I can check them?
There was a problem hiding this comment.
That's my understanding of our discussion for this bug yesterday. I do not think there is any written down text
…um limit is reached or if there are already global drawer(s) opened by user action
just-boris
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Runtime drawers with
defaultActive: truewere not opening when there were already open drawers on the page. This PR fixes that issue by updating the condition in theonDrawersRegisteredevent. Previously, runtime drawers withdefaultActive: truewould only set active drawers if none were open. Now, the condition has been adjusted to check if drawers withdefaultActiveare not currently open, allowing them to open regardless of other active drawers.Related links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.