Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adds flex-wrap to the property filter header #2874

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

orangevolon
Copy link
Contributor

@orangevolon orangevolon commented Oct 15, 2024

Description

Fixes the property filter component overflowing its container in small screens.

Related links, issue #, if available: AWSUI-59283

How has this been tested?

Visual tests dev pipeline.

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.21%. Comparing base (7693793) to head (20e60fe).

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #2874    +/-   ##
========================================
  Coverage   96.21%   96.21%            
========================================
  Files         761      761            
  Lines       21490    21490            
  Branches     7359     6959   -400     
========================================
  Hits        20676    20676            
- Misses        761      806    +45     
+ Partials       53        8    -45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orangevolon orangevolon force-pushed the dev-v3-alamiami branch 2 times, most recently from 36b3c6f to 41c8efb Compare October 16, 2024 12:17
@orangevolon orangevolon marked this pull request as ready for review October 17, 2024 10:05
@orangevolon orangevolon requested a review from a team as a code owner October 17, 2024 10:05
@orangevolon orangevolon requested review from at-susie and removed request for a team October 17, 2024 10:05
@orangevolon orangevolon marked this pull request as draft October 17, 2024 10:05
@orangevolon orangevolon removed the request for review from at-susie October 17, 2024 10:05
@orangevolon orangevolon force-pushed the dev-v3-alamiami branch 2 times, most recently from d6482b5 to 20e60fe Compare October 18, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant