chore: Fixes flakiness in dropdown width test #2883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2883 +/- ##
========================================
Coverage 96.20% 96.20%
========================================
Files 761 761
Lines 21445 21445
Branches 7340 6943 -397
========================================
Hits 20631 20631
- Misses 761 806 +45
+ Partials 53 8 -45 ☔ View full report in Codecov by Sentry. |
georgylobko
reviewed
Oct 16, 2024
| const [loading, setLoading] = useState(asyncLoading); | ||
| const onOpen = () => { | ||
| if (asyncLoading) { | ||
| setLoading(true); | ||
| setTimeout(() => setLoading(false), 500); | ||
| if (manualServerMock) { | ||
| window.__pendingCallbacks.push(() => setLoading(false)); |
There was a problem hiding this comment.
wouldn't it be easier to configure a synchronous response or to create an additional page with synchronous data flow instead of introducing these race condition handling?
There was a problem hiding this comment.
This page seems quite complex and I think it is likely that copying it would result in a lot of duplicated code. The manualServerMock only replaces the timeout with an explicit command to simplify integ tests and eliminate flakiness.
georgylobko
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removing dependency on test page timeout in dropdown width integ tests.
Similar fix: #2882
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.