Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Constrain main content when content paddings are disabled in toolbar #2889

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

fralongo
Copy link
Member

Description

Currently, when disableContentPaddings=true, the content of the toolbar goes behind the Split panel.

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@fralongo fralongo requested a review from a team as a code owner October 17, 2024 11:48
@fralongo fralongo requested review from just-boris and removed request for a team October 17, 2024 11:48
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.19%. Comparing base (a783fec) to head (af780f0).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2889      +/-   ##
==========================================
- Coverage   96.20%   96.19%   -0.01%     
==========================================
  Files         761      761              
  Lines       21447    21447              
  Branches     7276     6940     -336     
==========================================
- Hits        20633    20631       -2     
- Misses        761      808      +47     
+ Partials       53        8      -45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@include grid-column-full-content-width;
grid-column: 1 / -1;
@include desktop-only {
grid-column: 2 / span 4;
Copy link
Member

@just-boris just-boris Oct 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this one require a special treatment?

I checked on the preview page, found no issues when overriding this to grid-column: 2 / 5;

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, addressed!

@fralongo fralongo changed the title fix: Constain main content when content paddings are disabled in toolbar fix: Constrain main content when content paddings are disabled in toolbar Oct 17, 2024
@fralongo fralongo added this pull request to the merge queue Oct 17, 2024
Merged via the queue into main with commit 7693793 Oct 17, 2024
53 checks passed
@fralongo fralongo deleted the flongo-disable-paddings-toolbar branch October 17, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants