chore: Add size-limit check for runtime API #2894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
just-boris
commented
Oct 17, 2024
| const execa = require('execa'); | ||
| const { task } = require('../utils/gulp-utils'); | ||
|
|
||
| module.exports = task('size-limit', () => execa('size-limit', { stdio: 'inherit' })); |
There was a problem hiding this comment.
They offer a JS API too, but I decided to go with executable option, because only this way we can get readable declarations in package json instead of manual size comparison
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2894 +/- ##
==========================================
- Coverage 96.20% 96.19% -0.01%
==========================================
Files 761 761
Lines 21447 21447
Branches 7276 6940 -336
==========================================
- Hits 20633 20631 -2
- Misses 761 808 +47
+ Partials 53 8 -45 ☔ View full report in Codecov by Sentry. |
cansuaa
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add size-limit check for
/internal/pluginsexportRelated links, issue #, if available: n/a
How has this been tested?
Checked the build logs, there is a size-limit step now
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.