Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fixes embedded multiselect focus management #2896

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

pan-kot
Copy link
Member

@pan-kot pan-kot commented Oct 18, 2024

Description

The PR includes 2 fixes for embedded multiselect:

  • Options are selectable with Space (same as for multiselect w/o filter);
  • Focus highlight is removed when the list loses focus.
Screen.Recording.2024-10-18.at.10.06.10.mov

The change is needed for: #2739

How has this been tested?

  • New unit tests
Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pan-kot pan-kot requested a review from a team as a code owner October 18, 2024 08:06
@pan-kot pan-kot requested review from taheramr and removed request for a team October 18, 2024 08:06
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.20%. Comparing base (7693793) to head (3970f85).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2896      +/-   ##
==========================================
- Coverage   96.21%   96.20%   -0.01%     
==========================================
  Files         761      761              
  Lines       21490    21494       +4     
  Branches     7359     7353       -6     
==========================================
+ Hits        20676    20679       +3     
- Misses        761      807      +46     
+ Partials       53        8      -45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pan-kot pan-kot added this pull request to the merge queue Oct 18, 2024
Merged via the queue into main with commit cc75463 Oct 18, 2024
39 checks passed
@pan-kot pan-kot deleted the fix-embedded-multiselect-focus branch October 18, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants