Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adding page with reproducible problem #2898

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

dpitcock
Copy link
Contributor

@dpitcock dpitcock commented Oct 18, 2024

Description

Problem can be seen on path /light/app-layout/controlled-navigation/?appLayoutToolbar=true&navigationHide=false&applyNavOpenOverride=true&navOpenOverrideValue=false

on deployment. Go to https://d21d5uik3ws71m.cloudfront.net/components/b77b2547c6b1210f0de973956d6efb31ae58c212/dev-pages/index.html#/light/app-layout/controlled-navigation/?appLayoutToolbar=true&navigationHide=false&applyNavOpenOverride=true&navOpenOverrideValue=false

and refresh the page.

This is needed so a regression test can be completed

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.20%. Comparing base (7693793) to head (b77b254).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2898      +/-   ##
==========================================
- Coverage   96.21%   96.20%   -0.01%     
==========================================
  Files         761      761              
  Lines       21490    21490              
  Branches     7359     7350       -9     
==========================================
- Hits        20676    20675       -1     
- Misses        761      807      +46     
+ Partials       53        8      -45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dpitcock dpitcock marked this pull request as ready for review October 18, 2024 09:00
@dpitcock dpitcock requested a review from a team as a code owner October 18, 2024 09:00
@dpitcock dpitcock requested review from connorlanigan and removed request for a team October 18, 2024 09:00
@dpitcock dpitcock added this pull request to the merge queue Oct 18, 2024
Merged via the queue into main with commit b8d559d Oct 18, 2024
41 checks passed
@dpitcock dpitcock deleted the denpitco-nav-panel-sliding branch October 18, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants