Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add test to demonstrate cross-iframe getModalRoot usage #2902

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

just-boris
Copy link
Member

Description

Add a test to confirm this behavior is supported

Related links, issue #, if available: AWSUI-59828

How has this been tested?

This whole PR is a test

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.21%. Comparing base (b22ec75) to head (1d49437).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2902   +/-   ##
=======================================
  Coverage   96.21%   96.21%           
=======================================
  Files         761      761           
  Lines       21511    21511           
  Branches     7366     7357    -9     
=======================================
  Hits        20697    20697           
  Misses        761      761           
  Partials       53       53           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@just-boris just-boris marked this pull request as ready for review October 18, 2024 22:13
@just-boris just-boris requested a review from a team as a code owner October 18, 2024 22:13
@just-boris just-boris requested review from at-susie and removed request for a team October 18, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant