Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Revert Flashbar fixes #787

Merged
merged 2 commits into from
Feb 24, 2023
Merged

chore: Revert Flashbar fixes #787

merged 2 commits into from
Feb 24, 2023

Conversation

jperals
Copy link
Member

@jperals jperals commented Feb 24, 2023

Description

A bug in old versions of postcss-calc is causing some third party packages to fail when trying to minimize the CSS. We need to revert two commits until we are able to work around that issue by refactoring the SCSS code to use less nested expressions.

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jperals jperals marked this pull request as ready for review February 24, 2023 16:49
@jperals jperals requested a review from a team as a code owner February 24, 2023 16:49
@jperals jperals requested review from taheramr and removed request for a team February 24, 2023 16:49
@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Base: 93.30% // Head: 93.30% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (30a5d5a) compared to base (bc541ba).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #787      +/-   ##
==========================================
- Coverage   93.30%   93.30%   -0.01%     
==========================================
  Files         585      585              
  Lines       17141    17135       -6     
  Branches     4732     4726       -6     
==========================================
- Hits        15994    15988       -6     
  Misses       1067     1067              
  Partials       80       80              
Impacted Files Coverage Δ
src/app-layout/index.tsx 95.06% <ø> (ø)
src/app-layout/visual-refresh/notifications.tsx 100.00% <ø> (ø)
src/app-layout/notifications/index.tsx 100.00% <100.00%> (ø)
src/flashbar/collapsible-flashbar.tsx 97.90% <100.00%> (-0.06%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Al-Dani Al-Dani merged commit 40f40f5 into main Feb 24, 2023
@Al-Dani Al-Dani deleted the chore/revert-flashbar-fixes branch February 24, 2023 18:57
jperals added a commit that referenced this pull request Feb 27, 2023
abdhalees pushed a commit that referenced this pull request Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants