Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add show tables with schema #173

Merged

Conversation

apstndb
Copy link
Collaborator

@apstndb apstndb commented Jul 9, 2024

This PR adds named schemas support as SHOW TABLES <schema> command.
This is implemented as an extension of the existing SHOW TABLES to SHOW TABLES [<schema>], but it is explained as another command in README.md.

spanner> SHOW TABLES;
+----------------------------------------+
| Tables_in_apstndb-sampledb3            |
+----------------------------------------+
| Albums                                 |
| Concerts                               |
| Singers                                |
| Songs                                  |
+----------------------------------------+
71 rows in set (0.18 sec)

spanner> SHOW TABLES sch1;
+-----------------------------+
| Tables_in_apstndb-sampledb3 |
+-----------------------------+
| Albums                      |
| Singers                     |
| SingerView                  |
| Songs                       |
+-----------------------------+
4 rows in set (0.18 sec)

Related #172

Copy link
Collaborator

@yfuruyama yfuruyama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments, but LGTM. Thanks for submitting this change!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@apstndb apstndb requested a review from yfuruyama July 9, 2024 12:35
@yfuruyama
Copy link
Collaborator

Thanks for the additional change. LGTM!

@yfuruyama yfuruyama merged commit 9a93cfa into cloudspannerecosystem:master Jul 9, 2024
2 checks passed
@apstndb apstndb deleted the add-show-tables-with-schema branch July 9, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants