Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better README #17

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Better README #17

wants to merge 4 commits into from

Conversation

ozbillwang
Copy link

  • Add a better README.md
  • Fix bugs (parameters is not supported any more)

Copy link
Member

@phobologic phobologic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the example config/environment probably need more work before they should be leaned on too heavily. They've been neglected for a while now.

That said, we have a whole setup with stacker_cookiecutter, I'm wondering if we should just be pushing people towards that?

README.md Outdated

>NOTES: it will create aws resources and generate cost on your aws account. `make destroy` them all if not required any more.

Make sure you have permission to access aws, review below files if you need change anything.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might need more information around permission to access aws - that's a pretty broad definition.

Also, should probably change the second sentence to: review the files below if you need to change anything.

README.md Outdated
Make sure you have permission to access aws, review below files if you need change anything.

1) Adjust namespace to a global unique name, the name in example will be used in s3 bucket name, and has been used.
2) I have issue to start with pre_build task, if you get same problem, comment that session.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably just fix the pre_build task if there is an issue- can you share what problem you're seeing as an issue?

@@ -6,4 +6,4 @@
# will be used to prefix the CloudFormation stack names as well as the s3
# bucket that contains revisions of the stacker templates. This is the only
# required environment variable.
namespace:
namespace: stacker_blueprints
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is left blank, what error happens if you run this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got this error

stacker.exceptions.InvalidConfig: {'namespace': ConversionError([ErrorMessage(u'This field is required.', None)])}

@ozbillwang
Copy link
Author

@phobologic

I have updated with your suggestion, please review again.

README.md Outdated

An attempt at a common Blueprint library for use with `stacker <https://github.com/cloudtools/stacker>`_.

If you're new to stacker you may use `stacker_cookiecutter <https://github.com/cloudtools/stacker_cookiecutter>`_ to setup your project.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Quickstart should reference the cookie cutter project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants