-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add proveCashierShard
and proveCashierRoot
checks
#18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihoroleksiienko
requested review from
igorsenych-cw and
EvgeniiZaitsevCW
as code owners
October 28, 2024 16:09
ihoroleksiienko
changed the title
feat: add
feat: add Oct 29, 2024
isShard
and isRoot
checksisCashierShard
and isCashierRoot
checks
EvgeniiZaitsevCW
previously approved these changes
Oct 29, 2024
igorsenych-cw
force-pushed
the
feat/add-contract-determinant
branch
from
October 30, 2024 12:50
55b448c
to
5e7ff5b
Compare
igorsenych-cw
changed the title
feat: add
feat: add Nov 4, 2024
isCashierShard
and isCashierRoot
checksproveCashierShard
and proveCashierRoot
checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes
Implemented
proveCashierShard
andproveCashierRoot
validation checks inCashierShard
andCashier
contracts to verify whether a provided address corresponds to a validCashierShard
orCashier
instance.New declarations
ICashier interface:
ICashierShard interface:
Test coverage
New functionality was fully covered by tests.
Coverage details